Add check for duplicated doc aliases #89442
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Does this check only for duplicate aliases on one item, or could it also check for duplicates throughout a crate? I would love to see a warning lint for the latter. |
|
The latter is perfectly fine though. You can wrap a same C function differently a few times so I definitely don't think that we should warn about it. |
GuillaumeGomez
force-pushed
the
duplicated-doc-alias
branch
from
773f496
to
013aa37
Compare
|
Updated! |
GuillaumeGomez
added
the
A-lint
|
@GuillaumeGomez Libs, at least, has a policy against doing that, so it'd be helpful to have a lint we could turn on to enforce that. (This is not a blocker for this PR.) |
|
No, even libs don't want it: example. |
|
Fair enough, it wouldn't be universal. It might be useful as a warning to be opted out of, but in any case that's not a matter for this PR. |
|
I think a rustc-specific lint might be the way to go. But yes, out of scope here. ;) |
|
@bors r+ |
|
📌 Commit 013aa37 has been approved by |
bors
added
S-waiting-on-bors
…, r=estebank Add check for duplicated doc aliases r? `@estebank`
…arth Rollup of 10 pull requests Successful merges: - rust-lang#88706 (Normalize associated type projections when checking return type of main) - rust-lang#88828 (Use `libc::sigaction()` instead of `sys::signal()` to prevent a deadlock) - rust-lang#88871 (Fix suggestion for nested struct patterns) - rust-lang#89317 (Move generic error message to separate branches) - rust-lang#89351 (for signed wrapping remainder, do not compare lhs with MIN) - rust-lang#89442 (Add check for duplicated doc aliases) - rust-lang#89502 (Fix Lower/UpperExp formatting for integers and precision zero) - rust-lang#89523 (Make `proc_macro_derive_resolution_fallback` a future-breakage lint) - rust-lang#89532 (Document behavior of `MaybeLiveLocals` regarding enums and field-senstivity) - rust-lang#89546 (Make an initial guess for metadata size to reduce buffer resizes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
r? @estebank