use filter(|x| matches!(..)) instead of filter_map(|x| match x ... => Some(xy)) #90652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
matthiaskrgr
force-pushed
the
unnnec_filter_map
branch
from
05d34b5
to
723db0d
Compare
matthiaskrgr
force-pushed
the
unnnec_filter_map
branch
2 times, most recently
from
d2a9185
to
ed7e438
Compare
matthiaskrgr
commented
Nov 6, 2021
Comment on lines
-1373
to
1374
| .filter_map(|param| match param.kind { | ||
| GenericParamKind::Lifetime { .. } => Some(param), | ||
| _ => None, | ||
| .filter(|param| { | ||
| matches!(param.kind, GenericParamKind::Lifetime { .. }) | ||
| }) | ||
| .enumerate() | ||
| .map(|(late_bound_idx, param)| { |
There was a problem hiding this comment.
hrm, apparently rustfmt really prefers
.filter(|param| {
matches!(param.kind, GenericParamKind::Lifetime { .. })
})over
.filter(|param| matches!(param.kind, GenericParamKind::Lifetime { .. })):/
|
@bors r+ rollup |
|
📌 Commit ed7e438 has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
C-cleanup
spastorino
reviewed
Nov 8, 2021
| } | ||
| } | ||
|
|
||
| Some(field) | ||
| return true; |
There was a problem hiding this comment.
Suggested change
| return true; | |
| true |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 8, 2021
…yn514 use filter(|x| matches!(..)) instead of filter_map(|x| match x ... => Some(xy))
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 8, 2021
…yn514 use filter(|x| matches!(..)) instead of filter_map(|x| match x ... => Some(xy))
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2021
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#90494 (ARMv6K Horizon OS panic change) - rust-lang#90652 (use filter(|x| matches!(..)) instead of filter_map(|x| match x ... => Some(xy))) - rust-lang#90657 (Fix bug with `#[doc]` string single-character last lines) - rust-lang#90689 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.