Rollup of 6 pull requests #91013
Closed
Rollup of 6 pull requests #91013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following functions from `core::str` `const fn`:
- `from_utf8[_mut]` (`feature(const_str_from_utf8)`)
- `from_utf8_unchecked_mut` (`feature(const_str_from_utf8_unchecked_mut)`)
- `Utf8Error::{valid_up_to,error_len}` (`feature(const_str_from_utf8)`)
…_utf8_unchecked_mut` features
…=Aaron1011 Add `-Zassert-incr-state` to assert state of incremental cache Closes rust-lang#85864.
…=camelid Clean up mess for --show-coverage documentation It was somewhat duplicated for some reasons... Anyway, this remove this duplication and clean up a bit. r? `@camelid`
Mention `Vec::remove` in `Vec::swap_remove`'s docs Thought this was a nice addition.
add const generics test cc rust-lang#89829 (comment) r? rust-lang/project-const-generics
…=oli-obk
Make slice->str conversion and related functions `const`
This PR marks the following APIs as `const`:
```rust
// core::str
pub const fn from_utf8(v: &[u8]) -> Result<&str, Utf8Error>;
pub const fn from_utf8_mut(v: &mut [u8]) -> Result<&mut str, Utf8Error>;
pub const unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str;
impl Utf8Error {
pub const fn valid_up_to(&self) -> usize;
pub const fn error_len(&self) -> Option<usize>;
}
```
Everything but `from_utf8_unchecked_mut` uses `const_str_from_utf8` feature gate, `from_utf8_unchecked_mut` uses `const_str_from_utf8_unchecked_mut` feature gate.
---
I'm not sure why `from_utf8_unchecked_mut` was left out being non-`const`, considering that `from_utf8_unchecked` is not only `const`, but **`const` stable**.
---
r? `@oli-obk` (performance-only `const_eval_select` use)
…loat-ending-in-dot, r=sanxiyn Avoid suggesting literal formatting that turns into member access Fixes rust-lang#90974
|
@bors r+ p=6 rollup=never |
|
📌 Commit a1bd7c9 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit a1bd7c9 with merge c08e86d318e85ee7417589394335500ef536d237... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Zassert-incr-stateto assert state of incremental cache #90386 (Add-Zassert-incr-stateto assert state of incremental cache)Vec::removeinVec::swap_remove's docs #90480 (MentionVec::removeinVec::swap_remove's docs)const#90607 (Make slice->str conversion and related functionsconst)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup