Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #91048

Closed
wants to merge 37 commits into from

Commits on Oct 10, 2021

  1. Makes docs for references a little less confusing

    - Make clear that the `Pointer` trait is related to formatting
    - Make clear that `&T` (shared reference) implements `Send` (if `T: Send + Sync`)
    WaffleLapkin committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    7a47786 View commit details
    Browse the repository at this point in the history
  2. Update library/std/src/primitive_docs.rs

    Co-authored-by: fmease <liehr.exchange@gmx.net>
    WaffleLapkin and fmease committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    9a4530b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    26aec6c View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. Improve display of enum variants

    Use h3 and h4 for the variant name and the "Fields" subheading.
    Remove the "of T" part of the "Fields" subheading.
    Remove border-bottom from "Fields" subheading.
    Move docblock below "Fields" listing.
    jsha committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    69df43b View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Switch to normalized triples for Fuchsia

    This is a revert of e950d22 which is no
    longer needed since Clang now does normalization and handles all triple
    spellings.
    petrhosek committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    8c5fcc7 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    483cff7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    453e242 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b331b66 View commit details
    Browse the repository at this point in the history
  4. Update tests.

    m-ou-se committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    4877756 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a25751 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    09e4a75 View commit details
    Browse the repository at this point in the history
  7. Update test output.

    m-ou-se committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    b66fb64 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Point at source of trait bound obligations in more places

    Be more thorough in using `ItemObligation` and `BindingObligation` when
    evaluating obligations so that we can point at trait bounds that
    introduced unfulfilled obligations. We no longer incorrectly point at
    unrelated trait bounds (`substs-ppaux.verbose.stderr`).
    
    In particular, we now point at trait bounds on method calls.
    
    We no longer point at "obvious" obligation sources (we no longer have a
    note pointing at `Trait` saying "required by a bound in `Trait`", like
    in `associated-types-no-suitable-supertrait*`).
    
    Address part of rust-lang#89418.
    estebank committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    f5dc388 View commit details
    Browse the repository at this point in the history
  2. Change trait_defs.rs incremental hash test

    `predicates_of` no longer changes when changing a trait's front matter
    because we no longer include the trait's span in the identity trait
    obligation.
    estebank committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    3fe48b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    412793f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    abf70a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Configuration menu
    Copy the full SHA
    a6b31eb View commit details
    Browse the repository at this point in the history
  2. Point at impl blocks when they introduce unmet obligations

    Group obligations by `impl` block that introduced them.
    estebank committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    70e8240 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d443ea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1cadfe6 View commit details
    Browse the repository at this point in the history
  5. review comments

    estebank committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    2c173af View commit details
    Browse the repository at this point in the history
  6. Move tests from ui directory

    estebank committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    a8dcc87 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2f1a1f5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0304e16 View commit details
    Browse the repository at this point in the history
  9. rustdoc doctest: detect fn main after an unexpected semicolon

    The basic problem with this is that rustdoc, when hunting for `fn main`, will stop
    parsing after it reaches a fatal error. This unexpected semicolon was a fatal error,
    so in `src/test/rustdoc-ui/failed-doctest-extra-semicolon-on-item.rs`, it would wrap
    the doctest in an implied main function, turning it into this:
    
        fn main() {
            struct S {};
            fn main() {
                assert_eq!(0, 1);
            }
        }
    
    This, as it turns out, is totally valid, and it executes no assertions, so *it passes,*
    even though the user wanted it to execute the assertion.
    
    The Rust parser already has the ability to recover from these unexpected semicolons,
    but to do so, it needs to use the `parse_mod` function, so this commit changes it to do that.
    notriddle committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    214ad2f View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Configuration menu
    Copy the full SHA
    592178c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cdb0c29 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2d7857 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#88361 - WaffleLapkin:patch-2, r=jyn514

    Makes docs for references a little less confusing
    
    - Make clear that the `Pointer` trait is related to formatting
    - Make clear that the `Pointer` trait is implemented for references (previously it was confusing to first see that it's implemented and then see it in "expect")
    - Make clear that `&T` (shared reference) implements `Send` (if `T: Send + Sync`)
    matthiaskrgr authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    6320b99 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#89580 - estebank:trait-bounds-are-tricky, r…

    …=nagisa
    
    Point at source of trait bound obligations in more places
    
    Be more thorough in using `ItemObligation` and `BindingObligation` when
    evaluating obligations so that we can point at trait bounds that
    introduced unfulfilled obligations. We no longer incorrectly point at
    unrelated trait bounds (`substs-ppaux.verbose.stderr`).
    
    In particular, we now point at trait bounds on method calls.
    
    We no longer point at "obvious" obligation sources (we no longer have a
    note pointing at `Trait` saying "required by a bound in `Trait`", like
    in `associated-types-no-suitable-supertrait*`).
    
    We no longer point at associated items (`ImplObligation`), as they didn't
    add any user actionable information, they just added noise.
    
    Address part of rust-lang#89418.
    matthiaskrgr authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    204e81c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#90089 - jsha:enum-fields-headings, r=cameli…

    …d,GuillaumeGomez
    
    Improve display of enum variants
    
    Use h3 and h4 for the variant name and the "Fields" subheading.
    Remove the "of T" part of the "Fields" subheading.
    Remove border-bottom from "Fields" subheading.
    Move docblock below "Fields" listing.
    
    Fixes rust-lang#90061
    
    Demo:
    
    https://jacob.hoffman-andrews.com/rust/xmlparser-updated/xmlparser/enum.Token.html#variants
    https://jacob.hoffman-andrews.com/rust/fix-enum-variants/std/io/enum.ErrorKind.html#variants
    https://jacob.hoffman-andrews.com/rust/fix-enum-variants/std/result/enum.Result.html#variants
    
    r? `@camelid`
    matthiaskrgr authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    fad1fce View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#90510 - petrhosek:fuchsia-normalized, r=est…

    …ebank
    
    Switch to normalized triples for Fuchsia
    
    This is a revert of e950d22 which is no
    longer needed since Clang now does normalization and handles all triple
    spellings.
    matthiaskrgr authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    86568e5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0927113 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#90999 - RalfJung:miri_simd, r=oli-obk

    fix CTFE/Miri simd_insert/extract on array-style repr(simd) types
    
    The changed test would previously fail since `place_index` would just return the only field of `f32x4`, i.e., the array -- rather than *indexing into* the array which is what we have to do.
    
    The new helper methods will also be needed for rust-lang/miri#1912.
    
    r? ```@oli-obk```
    matthiaskrgr authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    8ec0aa2 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#91026 - notriddle:notriddle/rustdoc-doctest…

    …-semicolon, r=jyn514
    
    rustdoc doctest: detect `fn main` after an unexpected semicolon
    
    Fixes rust-lang#91014
    
    The basic problem with this is that rustdoc, when hunting for `fn main`, will stop parsing after it reaches a fatal error. This unexpected semicolon was a fatal error, so in `src/test/rustdoc-ui/failed-doctest-extra-semicolon-on-item.rs`, it would wrap the doctest in an implied main function, turning it into this:
    
        fn main() {
            struct S {};
            fn main() {
                assert_eq!(0, 1);
            }
        }
    
    This, as it turns out, is totally valid, and it executes no assertions, so *it passes,* even though the user wanted it to execute the assertion.
    
    The Rust parser already has the ability to recover from these unexpected semicolons, but to do so, it needs to use the `parse_mod` function, so this PR changes it to do that.
    matthiaskrgr authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    3e04549 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#91035 - GuillaumeGomez:put-back-removed-emp…

    …ty-line, r=camelid
    
    Put back removed empty line
    
    Fixes comment from rust-lang#90438 (comment).
    
    r? `@camelid`
    matthiaskrgr authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    f382877 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#91044 - r00ster91:x1b, r=joshtriplett

    Turn all 0x1b_u8 into '\x1b' or b'\x1b'
    
    Supersedes rust-lang#91040
    matthiaskrgr authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    a4775d2 View commit details
    Browse the repository at this point in the history