Don't copy llvm tools to sysroot when using download-ci-llvm #91720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Aaron1011
force-pushed
the
skip-llvm-ci-tools
branch
from
8db2bf0
to
faf407d
Compare
|
@Mark-Simulacrum I've updated the PR to copy each tool that exists on disk. |
|
@bors r+ p=1 (given ~widespread breakage) |
|
📌 Commit faf407d has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 9, 2021
…k-Simulacrum Don't copy llvm tools to sysroot when using download-ci-llvm Fixes rust-lang#91710
|
⌛ Testing commit faf407d with merge b50b92ec1f95b1ea5b7b087d79103f17c5bfac27... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bjorn3
reviewed
Dec 10, 2021
| @@ -1173,7 +1173,12 @@ impl Step for Assemble { | |||
| // (e.g. the `bootimage` crate). | |||
| for tool in LLVM_TOOLS { | |||
| let tool_exe = exe(tool, target_compiler.host); | |||
| builder.copy(&llvm_bin_dir.join(&tool_exe), &libdir_bin.join(&tool_exe)); | |||
| let src_path = llvm_bin_dir.join(&tool_exe); | |||
| // When using `donwload-ci-llvm`, some of the tools | |||
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (4a66a70): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91710