Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbot: Add autolabeling for T-compiler #91819

Merged
merged 1 commit into from
Dec 13, 2021
Merged

rustbot: Add autolabeling for T-compiler #91819

merged 1 commit into from
Dec 13, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Dec 12, 2021

This commit adds autolabeling for the T-compiler label, for PRs that
modify rustc's source code or tests (currently only src/test/ui).

This is possible now that rust-lang/triagebot#1321 has landed.

@camelid camelid added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-meta Area: Issues & PRs about the rust-lang/rust repository itself labels Dec 12, 2021
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2021
@camelid
Copy link
Member Author

camelid commented Dec 12, 2021

Note: This will likely conflict with #91817, so this should land after the other PR.

@camelid
Copy link
Member Author

camelid commented Dec 12, 2021

I'm not sure what the best way for the compiler team to decide on this is—an MCP doesn't seem right, since this is a small change. I'll just nominate it.

@camelid camelid added the I-compiler-nominated Nominated for discussion during a compiler team meeting. label Dec 12, 2021
@camelid
Copy link
Member Author

camelid commented Dec 12, 2021

cc @jackh726 – I know you were interested in having this

@camelid camelid added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2021
@bors
Copy link
Contributor

bors commented Dec 12, 2021

☔ The latest upstream changes (presumably #91825) made this pull request unmergeable. Please resolve the merge conflicts.

@jackh726
Copy link
Member

I don't think this really needs an MCP or nomination. There are no code changes here and it doesn't really affect anything other than just PR triage, I think (unless a PR is mislabeled and gets missed, but I think that's unlikely).

I'm going to go ahead and say r=me once rebased. But I'd like to tag @rust-lang/wg-triage @rust-lang/wg-prioritization, since those are the people this really affects.

@apiraino
Copy link
Contributor

really cool @camelid thanks!

@camelid
rustbot: Add autolabeling for T-compiler
1f65adf 
This commit adds autolabeling for the `T-compiler` label, for PRs that
modify rustc's source code or tests (currently only `src/test/ui`).

This is possible now that rust-lang/triagebot#1321 has landed.
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 12, 2021
@camelid camelid mentioned this pull request Dec 12, 2021
Closed
@camelid
Copy link
Member Author

camelid commented Dec 12, 2021

I'm actually going to hold off on approving this for now because of rust-lang/triagebot#1535 (comment).

@camelid camelid removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-compiler-nominated Nominated for discussion during a compiler team meeting. labels Dec 12, 2021
@camelid camelid assigned jackh726 and unassigned Mark-Simulacrum Dec 12, 2021
@camelid camelid added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Dec 12, 2021
@camelid
Copy link
Member Author

camelid commented Dec 12, 2021

@bors r=jackh726 rollup

@bors
Copy link
Contributor

bors commented Dec 12, 2021

📌 Commit 1f65adf has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Dec 12, 2021
@camelid
Copy link
Member Author

camelid commented Dec 12, 2021

Underlying issue should be fixed: rust-lang/triagebot#1535 (comment)

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 12, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2021
@bors
Auto merge of rust-lang#91841 - matthiaskrgr:rollup-zlhsg5a, r=matthi…
f7fd79a 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#91086 (Implement `TryFrom<&'_ mut [T]>` for `[T; N]`)
 - rust-lang#91091 (Stabilize `ControlFlow::{is_break, is_continue}`)
 - rust-lang#91749 (BTree: improve public descriptions and comments)
 - rust-lang#91819 (rustbot: Add autolabeling for `T-compiler`)
 - rust-lang#91824 (Make `(*mut T)::write_bytes` `const`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3b79d4f into master Dec 13, 2021
@bors bors deleted the compiler-autolabel branch December 13, 2021 03:52
@rustbot rustbot added this to the 1.59.0 milestone Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
7 participants
@camelid @rust-highfive @bors @jackh726 @apiraino @Mark-Simulacrum @rustbot