Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit an error for --cfg=) #92468

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Emit an error for --cfg=) #92468

merged 1 commit into from
Jan 2, 2022

Commits on Jan 1, 2022

  1. Emit an error for --cfg=) 

    Fixes rust-lang#73026

See also: rust-lang#64467, rust-lang#89468

The issue stems from a `FatalError` being silently raised in
`panictry_buffer`. Normally this is not a problem, because
`panictry_buffer` emits the causes of the error, but they are not
themselves fatal, so they get filtered out by the silent emitter.

To fix this, we use a parser entrypoint which doesn't use
`panictry_buffer`, and we handle the error ourselves.
    @meithecatte
    meithecatte committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    193342e View commit details
    Browse the repository at this point in the history