Clarify the usage-of-qualified-ty error message.
#93357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup=always |
bors
added
S-waiting-on-bors
nnethercote
force-pushed
the
clarify-usage-of-qualified-ty
branch
from
7fc3336
to
1281e20
Compare
lcnr
reviewed
Jan 27, 2022
I found this message confusing when I encountered it. This commit makes it clearer that you have to import the unqualified type yourself.
nnethercote
force-pushed
the
clarify-usage-of-qualified-ty
branch
from
1281e20
to
696d503
Compare
|
@bors r=lcnr |
|
📌 Commit 696d503 has been approved by |
|
For posterity, here is the Zulip conversation about this. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#91641 (Define c_char using cfg_if rather than repeating 40-line cfg) - rust-lang#92899 (Mention std::iter::zip in Iterator::zip docs) - rust-lang#93193 (Add test for stable hash uniqueness of adjacent field values) - rust-lang#93325 (Introduce a limit to Levenshtein distance computation) - rust-lang#93339 (rustdoc: add test case for multiple traits and erased names) - rust-lang#93357 (Clarify the `usage-of-qualified-ty` error message.) - rust-lang#93363 (`#[rustc_pass_by_value]` cleanup) - rust-lang#93365 (More arena cleanups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this message confusing when I encountered it. This commit makes
it clearer that you have to import the unqualified type yourself.
r? @lcnr