Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: correct reading of flags for llvm #94466

Merged
merged 1 commit into from
Mar 4, 2022
Merged

bootstrap: correct reading of flags for llvm #94466

merged 1 commit into from
Mar 4, 2022

Commits on Mar 3, 2022

  1. bootstrap: correct reading of flags for llvm 

    First, this reverts the `CFLAGS`/`CXXFLAGS` of rust-lang#93918. Those flags are
already read by `cc` and populated into `Build` earlier on in the
process. We shouldn't be overriding that based on `CFLAGS`, since `cc`
also respects overrides like `CFLAGS_{TARGET}` and `HOST_CFLAGS`, which
we want to take into account.

Second, this adds the same capability to specify target-specific
versions of `LDFLAGS` as we have through `cc` for the `C*` flags:
https://github.com/alexcrichton/cc-rs#external-configuration-via-environment-variables

Note that this also necessitated an update to compiletest to treat
CXXFLAGS separately from CFLAGS.
    Jon Gjengset committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    9c05f0b View commit details
    Browse the repository at this point in the history