Stop using CRATE_DEF_INDEX outside of metadata encoding. #96142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CRATE_DEF_ID` and `CrateNum::as_def_id` are almost always what we want.
cjgillot
added
the
C-cleanup
|
Some changes occurred in cc @camelid Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rustbot
added
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -316,7 +303,7 @@ fn upstream_monomorphizations_provider( | |||
| // If there are multiple monomorphizations available, | |||
| // we select one deterministically. | |||
| let other_cnum = *e.get(); | |||
| if cnum_stable_ids[other_cnum] > cnum_stable_ids[cnum] { | |||
| if tcx.stable_crate_id(other_cnum) > tcx.stable_crate_id(cnum) { | |||
There was a problem hiding this comment.
As I understand this is a different order than used previously, but it's still deterministic so it's ok.
|
@bors r+ |
|
📌 Commit 07ee031 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 18, 2022
…ochenkov Stop using CRATE_DEF_INDEX outside of metadata encoding. `CRATE_DEF_ID` and `CrateNum::as_def_id` are almost always what we want. We should not manipulate raw `DefIndex` outside of metadata encoding.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 19, 2022
…ochenkov Stop using CRATE_DEF_INDEX outside of metadata encoding. `CRATE_DEF_ID` and `CrateNum::as_def_id` are almost always what we want. We should not manipulate raw `DefIndex` outside of metadata encoding.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 19, 2022
…ochenkov Stop using CRATE_DEF_INDEX outside of metadata encoding. `CRATE_DEF_ID` and `CrateNum::as_def_id` are almost always what we want. We should not manipulate raw `DefIndex` outside of metadata encoding.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#94493 (Improved diagnostic on failure to meet send bound on future in a foreign crate) - rust-lang#95809 (Fix typo in bootstrap.py) - rust-lang#96086 (Remove `--extern-location` and all associated code) - rust-lang#96089 (`alloc`: make `vec!` unavailable under `no_global_oom_handling`) - rust-lang#96122 (Fix an invalid error for a suggestion to add a slice in pattern-matching) - rust-lang#96142 (Stop using CRATE_DEF_INDEX outside of metadata encoding.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
…ochenkov Stop using CRATE_DEF_INDEX outside of metadata encoding. `CRATE_DEF_ID` and `CrateNum::as_def_id` are almost always what we want. We should not manipulate raw `DefIndex` outside of metadata encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRATE_DEF_IDandCrateNum::as_def_idare almost always what we want. We should not manipulate rawDefIndexoutside of metadata encoding.