Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AddrParseError description #96168

Merged

Commits on Apr 19, 2022

  1. Improve AddrParseError description

    The existing description was incorrect for socket addresses, and
    misleading: users would see “invalid IP address syntax” and suppose they
    were supposed to provide an IP address rather than a socket address.
    
    I contemplated making it two variants (IP, socket), but realised we can
    do still better for the IPv4 and IPv6 types, so here it is as six.
    
    I contemplated more precise error descriptions (e.g. “invalid IPv6
    socket address syntax: expected a decimal scope ID after %”), but that’s
    a more invasive change, and probably not worthwhile anyway.
    chris-morgan committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    0255398 View commit details
    Browse the repository at this point in the history