Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running bootstrap tests on a fresh clone #96375

Merged
merged 1 commit into from
May 11, 2022

Commits on May 10, 2022

  1. Fix running bootstrap tests on a fresh clone

    In rust-lang#96303, I changed the tests not to manage submodules, with the main
    goal of avoiding a clone for llvm-project. Unfortunately, there are some tests
    which depend on submodules - I didn't notice locally because they were already checked out for me,
    and CI doesn't use submodule handling at all. Fresh clones, however, were impacted:
    ```
    failures:
    
    ---- builder::tests::defaults::doc_default stdout ----
    thread 'main' panicked at 'fs::read_dir(builder.src.join(&relative_path).join("redirects")) failed with No such file or directory (os error 2)', src/bootstrap/doc.rs:232:21
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    
    ---- builder::tests::dist::dist_only_cross_host stdout ----
    thread 'main' panicked at 'fs::read_to_string(&toml_file_name) failed with No such file or directory (os error 2)', src/bootstrap/lib.rs:1314:20
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    ```
    
    Try and get the best of both worlds by only checking out the submodules actually used in tests.
    jyn514 committed May 10, 2022
    Configuration menu
    Copy the full SHA
    212fc21 View commit details
    Browse the repository at this point in the history