Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #96427

Closed
wants to merge 19 commits into from

Commits on Mar 23, 2022

  1. Configuration menu
    Copy the full SHA
    9f4934e View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Implement Default for AssertUnwindSafe

    Trait impls are still insta-stable yeah...?
    SoniEx2 authored Apr 11, 2022
    Configuration menu
    Copy the full SHA
    8d5a496 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Fix a bug in the ptx-kernel calling convention where structs was pass…

    …ed indirectly
    
    Structs being passed indirectly is suprpising and have a high chance not to work as the device and host usually do not share memory.
    kjetilkjeka committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    352abba View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Configuration menu
    Copy the full SHA
    4280c81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c95c0b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0233abe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dff7f25 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Configuration menu
    Copy the full SHA
    74853ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5bf5acc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    941e194 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Remove references to git.io

    ehuss committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    159b95d View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#94022 - jongiddy:cow-into-owned-docs, r=Dyl…

    …an-DPC
    
    Clarify that `Cow::into_owned` returns owned data
    
    Two sections of the `Cow::into_owned` docs imply that `into_owned` returns a `Cow`. Clarify that it returns the underlying owned object, either cloned or extracted from the `Cow`.
    GuillaumeGomez authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    24dcda0 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#94703 - kjetilkjeka:nvptx-kernel-args-abi2,…

    … r=nagisa
    
    Fix codegen bug in "ptx-kernel" abi related to arg passing
    
    I found a codegen bug in the nvptx abi related to that args are passed as ptrs ([see comment](rust-lang#38788 (comment))), this is not as specified in the [ptx-interoperability doc](https://docs.nvidia.com/cuda/ptx-writers-guide-to-interoperability/) or how C/C++ does it. It will also almost always fail in practice since device/host uses different memory spaces for most hardware.
    
    This PR fixes the bug and add tests for passing structs to ptx kernels.
    
    I observed that all nvptx assembly tests had been marked as [ignore a long time ago](rust-lang#59752 (comment)). I'm not sure if the new one should be marked as ignore, it passed on my computer but it might fail if ptx-linker is missing on the server? I guess this is outside scope for this PR and should be looked at in a different issue/PR.
    
    I only fixed the nvptx64-nvidia-cuda target and not the potential code paths for the non-existing 32bit target. Even though 32bit nvptx is not a supported target there are still some code under the hood supporting codegen for 32 bit ptx. I was advised to create an MCP to find out if this code should be removed or updated.
    
    Perhaps `@RDambrosio016` would have interest in taking a quick look at this.
    GuillaumeGomez authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f1fbc71 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#95949 - SoniEx2:patch-5, r=m-ou-se

    Implement Default for AssertUnwindSafe
    
    Trait impls are still insta-stable yeah...?
    GuillaumeGomez authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    8621a2f View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#96361 - GuillaumeGomez:es6, r=notriddle

    Switch JS code to ES6
    
    Considering it's already quite big, I'll do the remaining files in another PR.
    
    Part of rust-lang#93058.
    
    r? `@notriddle`
    GuillaumeGomez authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    77e607e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#96372 - compiler-errors:field-method-sugges…

    …t, r=oli-obk
    
    Suggest calling method on nested field when struct is missing method
    
    Similar to the suggestion to change `x.field` to `x.nested.field`, implement a similar suggestion for when `x.method()` should be replaced with `x.nested.method()`.
    GuillaumeGomez authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    8b71be8 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#96386 - SparrowLii:des_field, r=jackh726

    simplify `describe_field` func in borrowck's diagnostics part
    
    This PR simplify the `describe_field` func in borrowck's diagnostics part, besides fix the FIXME in it.
    GuillaumeGomez authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    1c1b418 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#96400 - JakobDegen:shallow-init-docs, r=Dyl…

    …an-DPC
    
    Correct documentation for `Rvalue::ShallowInitBox`
    
    As a part of the big MIR docs PR, I had added a comment indicating that `Rvalue::ShallowInitBox` is disallowed after drop elaboration, but this is not true (no idea why I thought it was). Codegen has support for it, and trying to enforce this rule in the validator causes compiling core to ICE on the very first `box` statement.
    
    That being said, this `Rvalue` probably *should* be banned after drop elaboration - it doesn't seem like it's still useful for much. However, I do not have time right now to actually go investigate how difficult a change that is to make, so in the meantime fixing the docs to reflect the current situation seems like the right step.
    
    r? rust-lang/mir-opt
    GuillaumeGomez authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    5c026e3 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#96415 - ehuss:git-io, r=bjorn3

    Remove references to git.io
    
    The git.io service is shutting down soon (see https://github.blog/changelog/2022-04-25-git-io-deprecation/). This removes the references of those short links with the actual destination.
    GuillaumeGomez authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    898059c View commit details
    Browse the repository at this point in the history