Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make "Assemble stage1 compiler" orders of magnitude faster" #96905

Merged
merged 1 commit into from
May 10, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 10, 2022

Reverts #96803. This caused llvm-tools-nightly to fail when installing with rustup-toolchain-install-master because of the presence of symlinks. I'm not sure how the symlinks got in there, but revert the PR for now while I figure it out.

r? @Mark-Simulacrum cc @RalfJung

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022
@RalfJung
Copy link
Member

@bors r=Mark-Simulacrum
(via Zulip)

@bors
Copy link
Contributor

bors commented May 10, 2022

📌 Commit 89e0c29 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2022
@matthiaskrgr
Copy link
Member

@bors p=1 (make sure this gets in before next nightly, just in case...)

@bors
Copy link
Contributor

bors commented May 10, 2022

⌛ Testing commit 89e0c29 with merge fee75fb...

@bors
Copy link
Contributor

bors commented May 10, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing fee75fb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 10, 2022
@bors bors merged commit fee75fb into rust-lang:master May 10, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 10, 2022
@jyn514 jyn514 deleted the revert-96803-faster-assemble branch May 10, 2022 20:51
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fee75fb): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 0 1 0
mean2 N/A N/A N/A -0.2% N/A
max N/A N/A N/A -0.2% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants