Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote replace target in bootstrap configure #97280

Merged
merged 1 commit into from
May 22, 2022
Merged

Quote replace target in bootstrap configure #97280

merged 1 commit into from
May 22, 2022

Conversation

yue4u
Copy link
Contributor

@yue4u yue4u commented May 22, 2022

close #97263

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2022
@Mark-Simulacrum
Copy link
Member

This looks okay to me, though we might want to rename the target that's the cause of this to something avoiding dots in the name given the problems that's causing.

@bors r+

@bors
Copy link
Contributor

bors commented May 22, 2022

📌 Commit 1532fd8 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2022
@jackh726 jackh726 mentioned this pull request May 22, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2022
@bors
Auto merge of rust-lang#97283 - jackh726:rollup-ga84p7n, r=jackh726
0a437b2 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97043 (Move some tests to more reasonable directories)
 - rust-lang#97206 (Do leak check after function pointer coercion)
 - rust-lang#97275 (small change)
 - rust-lang#97277 (Avoid accidentally enabling unstable features in compilers (take 2))
 - rust-lang#97280 (Quote replace target in bootstrap configure)

Failed merges:

 - rust-lang#97214 (Finish bumping stage0)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b392cdf into rust-lang:master May 22, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

Bootstrapping logic has trouble with target triples with dots in the name (e.g. thumbv8m.main-none-eabihf)
5 participants
@yue4u @rust-highfive @Mark-Simulacrum @bors @rustbot