Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more context when denying invalid type params #97471

Merged
merged 7 commits into from
Jun 3, 2022
Merged

Provide more context when denying invalid type params #97471

merged 7 commits into from
Jun 3, 2022

Commits on Jun 1, 2022

  1. Rework prohibit_generics

    @estebank
    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    f023b92 View commit details
    Browse the repository at this point in the history

  2. Provide more context when denying invalid type params

    @estebank
    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9b2d80a View commit details
    Browse the repository at this point in the history

  3. More accurately handle suggestions 

    * Confirm the path segment being modified is an `enum`
* Check whether type has type param before suggesting changing `Self`
* Wording changes
* Add clarifying comments
* Suggest removing args from `Self` if the type doesn't have type params
    @estebank
    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    532671b View commit details
    Browse the repository at this point in the history

  4. Fix test

    @estebank
    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3d60691 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @estebank
    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    196a30e View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Make output more specific

    @estebank
    estebank committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    ad63f90 View commit details
    Browse the repository at this point in the history

  2. review comments

    @estebank
    estebank committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    cd8cfbf View commit details
    Browse the repository at this point in the history