Fix reachability analysis for const methods #97716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
issue-97708
branch
2 times, most recently
from
67d63c8
to
dfc9294
Compare
compiler-errors
force-pushed
the
issue-97708
branch
from
dfc9294
to
15cccb9
Compare
compiler-errors
changed the title
wesleywiser
approved these changes
Jun 4, 2022
|
Thanks @compiler-errors! @bors r+ |
|
📌 Commit 15cccb9 has been approved by |
bors
added
S-waiting-on-bors
|
Yeah the first approach was kinda wonky. It only later realized to me that we should be using |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 4, 2022
…eywiser Fix reachability analysis for const methods Use `method_might_be_inlined` directly for `ImplItemKind::Fn` instead of duplicating the logic in `def_id_represents_local_inlined_item`. This is parallel to how we use `item_might_be_inlined` for `ItemKind::Fn` in that same body. Fixes rust-lang#97708
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 4, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#96642 (Avoid zero-sized allocs in ThinBox if T and H are both ZSTs.) - rust-lang#97647 (Lazily allocate and initialize pthread locks.) - rust-lang#97715 (Support the `#[expect]` attribute on fn parameters (RFC-2383)) - rust-lang#97716 (Fix reachability analysis for const methods) - rust-lang#97722 (Tighten spans for bad fields in struct deriving `Copy`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Hm, i had hoped that this would also fix #96857 but it seems it didn't :/ :sweat_smile: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
method_might_be_inlineddirectly forImplItemKind::Fninstead of duplicating the logic indef_id_represents_local_inlined_item.This is parallel to how we use
item_might_be_inlinedforItemKind::Fnin that same body.Fixes #97708