Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unreachable coverage generation for inlined functions #98868

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Fix unreachable coverage generation for inlined functions #98868

merged 4 commits into from
Jul 22, 2022

Commits on Jul 8, 2022

  1. Add SourceScope::inlined_instance

    @tmiasko
    tmiasko committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    7e7d007 View commit details
    Browse the repository at this point in the history

  2. Use extend instead of repeatedly pushing into a vec

    @tmiasko
    tmiasko committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    fadae87 View commit details
    Browse the repository at this point in the history

  3. Fix unreachable coverage generation for inlined functions 

    To generate a function coverage we need at least one coverage counter,
so a coverage from unreachable blocks is retained only when some live
counters remain.

The previous implementation incorrectly retained unreachable coverage,
because it didn't account for the fact that those live counters can
belong to another function due to inlining.
    @tmiasko
    tmiasko committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    62ab4b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Update compiler/rustc_mir_transform/src/simplify.rs

    @wesleywiser
    wesleywiser authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    9473141 View commit details
    Browse the repository at this point in the history