Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining uses of box syntax from librustdoc #99577

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Remove remaining uses of box syntax from librustdoc #99577

merged 6 commits into from
Jul 29, 2022

Commits on Jul 29, 2022

  1. Remove box syntax from Box<rustdoc::clean::types::ItemKind> construction 

    The type has 240 bytes according to compiler internal rustdoc.
    @est31
    est31 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    e62f6a0 View commit details
    Browse the repository at this point in the history

  2. Remove box syntax from doctest.rs

    @est31
    est31 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    79246e8 View commit details
    Browse the repository at this point in the history

  3. Remove box_syntax feature gate from librustdoc

    @est31
    est31 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    0bf65c7 View commit details
    Browse the repository at this point in the history

  4. Box TypedefItem, ImplItem, AssocTypeItem variants of ItemKind 

    This reduces ItemKind size from 224 bytes to 160 bytes.
    @est31
    est31 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    96c051f View commit details
    Browse the repository at this point in the history

  5. Box FunctionItem, TyMethodItem, MethodItem, ForeignFunctionItem 

    This reduces ItemKind size from 160 bytes to 112 bytes
    @est31
    est31 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    1116fc1 View commit details
    Browse the repository at this point in the history

  6. Statically ensure the size of ItemKind

    @est31
    est31 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    fabb4b0 View commit details
    Browse the repository at this point in the history