Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline lint checking #99888

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Conversation

nnethercote
Copy link
Contributor

The early (AST) and late (HIR) lint checkers have a number of functions that aren't used by rustc or clippy. Might as well remove them -- it's not like there's a canonical API here, as shown by the ad hoc use of check_foo/check_foo_post combinations.

r? @cjgillot

They're not used by rustc or clippy.
Because the default is empty and it's never overridden. This means
`walk_ident` can also be removed, because it does nothing.
They're not used by rustc or clippy.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2022
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 29, 2022

📌 Commit 74e9a29 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#99227 (Fix thumbv4t-none-eabi frame pointer setting)
 - rust-lang#99518 (Let-else: break out scopes when a let-else pattern fails to match)
 - rust-lang#99671 (Suggest dereferencing index when trying to use a reference of usize as index)
 - rust-lang#99831 (Add Fuchsia platform support documentation)
 - rust-lang#99881 (fix ICE when computing codegen_fn_attrs on closure with non-fn parent)
 - rust-lang#99888 (Streamline lint checking)
 - rust-lang#99891 (Adjust an expr span to account for macros)
 - rust-lang#99904 (Cleanup html whitespace)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5c3b6d6 into rust-lang:master Jul 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 30, 2022
@nnethercote nnethercote deleted the streamline-visitors branch July 30, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants