Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add full name for ICE #1552

Merged
merged 3 commits into from
Jan 11, 2023
Merged

add full name for ICE #1552

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa21b33
add full name for ICE
gftea Jan 11, 2023
a338ebc
fix line width
gftea Jan 11, 2023
57520eb
Update src/queries/query-evaluation-model-in-detail.md
gftea Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/queries/query-evaluation-model-in-detail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ OK as long as the mutation is not observable. This is achieved by two things:
- Before a result is stolen, we make sure to eagerly run all queries that
might ever need to read that result. This has to be done manually by calling
those queries.
- Whenever a query tries to access a stolen result, we make the compiler ICE so
that such a condition cannot go unnoticed.
- Whenever a query tries to access a stolen result, we make an ICE
(Internal Compiler Error) so that such a condition cannot go unnoticed.

This is not an ideal setup because of the manual intervention needed, so it
should be used sparingly and only when it is well known which queries might
Expand Down