Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start on walkthrough #237

Merged
merged 5 commits into from
Nov 26, 2018
Merged

start on walkthrough #237

merged 5 commits into from
Nov 26, 2018

Conversation

mark-i-m
Copy link
Member

This is basically my experience when working on rust-lang/rfcs#2298 which is now about to be stabilized! What a journey 🗺️ 😄

@nikomatsakis nikomatsakis mentioned this pull request Nov 11, 2018
Closed
20 tasks
@mark-i-m mark-i-m changed the title [WIP] start on walkthrough start on walkthrough Nov 19, 2018
@mark-i-m
Copy link
Member Author

I think this is ready... anyone have comments?

@nikomatsakis nikomatsakis self-requested a review November 20, 2018 20:34
@nikomatsakis nikomatsakis self-assigned this Nov 20, 2018
@nikomatsakis
Copy link
Contributor

I'll do a review @mark-i-m !

nikomatsakis
nikomatsakis approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@nikomatsakis nikomatsakis merged commit 946d56b into rust-lang:master Nov 26, 2018
@mark-i-m mark-i-m deleted the walkthrough branch June 15, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mark-i-m @nikomatsakis