Eagerly load self-profile files #1798
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we can avoid generating a unique directory for the self-profiles (reverted in the last commit), and we also avoid loading the self-profile files twice from disk. The disadvantage is that all self-profiles for a single benchmark (so for all combinations of profiles and scenarios) is now held in memory. But I think that shouldn't be an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent self-profile refactorings, I thought that we might simplify the self-profile handling even more, by eagerly loading the self-profile file into memory, which avoids the hack with generating a unique self-profile directory.
This also simplifies code.