Expand when only one graph is selected #1988
Open
+57
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s7tya
force-pushed
the
expand-if-only-one-graph-selected
branch
from
85b4e0f
to
92bc848
Compare
s7tya
force-pushed
the
expand-if-only-one-graph-selected
branch
from
92bc848
to
e3f05d5
Compare
|
Thank you! I tried to make the calculations a bit simpler, and tested it with 1/4 columns on desktop/mobile. Let me know what you think! |
|
Thanks! I think it looks great on mobile screens, but on larger screens, isn't the height getting fixed at 300px?
|
|
It should not be ( It looks like this on my side: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1938
Though it's bit tricky that I'm using some elements' width and height to calculate graphs size, it might be somewhat useful.