-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recursive settings and clean up test whitelist #4142
Changes from 1 commit
60ed5e9
3f40a9e
009421c
fa3395d
ddd5c6e
278a4f1
f0cce5b
010c678
759aaf7
58c6c79
ce8493a
445f71e
5524752
8d66e73
dc5fb24
e086436
a98b1cd
6af9fed
04fdc7a
db9962a
8ef90d1
a6509fe
e6d5aea
a5232a2
e81d184
e7af9c1
02e740d
2ade088
1c06692
4343c4f
9a79fca
b9c5fe1
474ca53
5f5c9d1
b05a902
d261e9c
dd2e0ca
975c19d
100068d
d9f7064
69f6b76
b68f06b
991ab17
fffc7ff
037c064
25d5f9f
0e3d5f0
b56a370
24fa639
5b62710
20a52b7
b042b37
cbf44c8
4861ef4
35121ea
5936675
0a45e91
b272c77
256c024
77a7f95
0b8341f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,21 +21,10 @@ const DIFF_CONTEXT_SIZE: usize = 3; | |
|
||
// A list of files on which we want to skip testing. | ||
const SKIP_FILE_WHITE_LIST: &[&str] = &[ | ||
"issue-3253/paths", | ||
"issue-3434/no_entry.rs", | ||
"issue-3665/sub_mod.rs", | ||
// Testing for issue-3779 | ||
"issue-3779/ice.rs", | ||
// These files and directory are a part of modules defined inside `cfg_if!`. | ||
"cfg_if/mod.rs", | ||
"cfg_if/detect", | ||
"issue-3253/foo.rs", | ||
"issue-3253/bar.rs", | ||
"issue-3253/paths", | ||
// These files and directory are a part of modules defined inside `cfg_attr(..)`. | ||
"cfg_mod/dir", | ||
"cfg_mod/bar.rs", | ||
"cfg_mod/foo.rs", | ||
"cfg_mod/wasm32.rs", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Between adding the recursive config option to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to keep these files in the list to make sure that |
||
// We want to ensure `recursive` is working correctly, so do not test | ||
// these files directly | ||
"configs/recursive/disabled/foo.rs", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ | |
//! * `mips64`: [`is_mips64_feature_detected`] | ||
//! * `powerpc`: [`is_powerpc_feature_detected`] | ||
//! * `powerpc64`: [`is_powerpc64_feature_detected`] | ||
// rustfmt-recursive: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the system/idempotence checks need the inline config options to be at the top of the files as well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, @calebcartwright ! Even if the config options can 'survive' being down below, I also like how having them at the top matches with their location in other files already. I've gone ahead and moved them up there. I'll wait on topecongiro's feedback on the particular files we can take off the whitelist, then make those changes as well (feel free to weigh in there too if you've got strong opinions). |
||
|
||
#![unstable(feature = "stdsimd", issue = "27731")] | ||
#![feature(const_fn, staged_api, stdsimd, doc_cfg, allow_internal_unstable)] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placing a remaining whitelisted file up in lexicographical order after 'cleaning house'