Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4099: trailing_comma + struct_field_align_threshold -> removing a struct's commas #4201

Merged
merged 2 commits into from
May 25, 2020

Conversation

theo-lw
Copy link
Contributor

@theo-lw theo-lw commented May 25, 2020

This PR addresses #4099.

It looks to me that fields are separated into groups based on newlines. However, the trailing comma for each group may be removed. I added code that ensures that only the final group of fields can have their trailing comma removed.

Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@ytmimi
Copy link
Contributor

ytmimi commented Mar 31, 2022

Backport was completed by #5159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants