Windows: Try using symlinks if they're allowed #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Feb 27, 2024
|
Something like that? |
djc
approved these changes
Feb 27, 2024
|
This seems okay, going to merge this. Thanks! |
|
@ChrisDenton I don't use Windows personally but I have a question: will this create a possibly inconsistent state where one part of the installation is organized with symlinks and another part with juncture points? |
|
That could happen but I can't think of a case where the type of link would matter to us. Except, as previously mentioned, when moving the rustup directory. In that case you'll end up with some links being broken while others aren't but I'm not sure that's any worse than all links being broken. |
1 task
eandre
added a commit
to eandre/encore
that referenced
this pull request
Sep 16, 2024
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
eandre
added a commit
to eandre/encore
that referenced
this pull request
Sep 16, 2024
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
eandre
added a commit
to encoredev/encore
that referenced
this pull request
Sep 16, 2024
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, creating symlinks is not allowed unless developer mode is enabled or a specific permission is granted. Therefore this optimistically attempts to use symlinks first, before falling back to juncture points in the event that fails.
Resolves #3677