Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rustup-mode)!: don't install toolchain on rustup --version #3948

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jul 15, 2024

Supersedes #2658.

@rami3l rami3l force-pushed the feat/no-implicit-install-0 branch 2 times, most recently from d6eb2c9 to 579b855 Compare July 15, 2024 02:36
@rami3l rami3l requested a review from djc July 15, 2024 02:36
@rami3l rami3l marked this pull request as ready for review July 15, 2024 02:36
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/config.rs Outdated Show resolved Hide resolved
src/cli/rustup_mode.rs Outdated Show resolved Hide resolved
@rami3l rami3l force-pushed the feat/no-implicit-install-0 branch from 579b855 to d0d9bdb Compare July 15, 2024 08:19
@rami3l rami3l enabled auto-merge July 15, 2024 08:23
@rami3l rami3l added this pull request to the merge queue Jul 15, 2024
Merged via the queue into rust-lang:master with commit 4149df6 Jul 15, 2024
27 checks passed
@rami3l rami3l deleted the feat/no-implicit-install-0 branch July 15, 2024 09:00
@rami3l rami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants