Refactor stdsimd #640
Merged
Refactor stdsimd #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnzlbg
commented
Jan 21, 2019
| @@ -78,7 +78,8 @@ struct Cache(AtomicU64); | |||
| impl Cache { | |||
| /// Creates an uninitialized cache. | |||
| const fn uninitialized() -> Self { | |||
| Cache(AtomicU64::new(u64::max_value())) | |||
| const X: AtomicU64 = AtomicU64::new(u64::max_value()); | |||
| Self(X) | |||
There was a problem hiding this comment.
(repeating from Discord: I wasn't able to reproduce either... I'll see if I have time to test this locally; for the time being, this hack is fine, and AtomicU64 is stable in 1.34 so hopefully that makes the hack go away... However, when using the hack in the future, please cc myself and @oli-obk...)
|
So @alexcrichton this should be all green now. In some targets |
This commit:
* renames `coresimd` to `core_arch` and `stdsimd` to `std_detect`
* `std_detect` does no longer depend on `core_arch` - it is a freestanding
`no_std` library that only depends on `core` - it is renamed to `std_detect`
* moves the top-level coresimd and stdsimd directories into the appropriate
crates/... directories - this simplifies creating crate.io releases of these crates
* moves the top-level `coresimd` and `stdsimd` sub-directories into their
corresponding crates in `crates/{core_arch, std_detect}`.
|
I am merging this. We can iterate on this in tree. |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jan 29, 2019
Update stdsimd This is the companion PR to rust-lang/stdarch#640 r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
renames
coresimdtocore_archandstdsimdtostd_detectstd_detectdoes no longer depend oncore_arch- it is a freestandingno_std(on some archs) library that only depends oncoremoves the top-level coresimd and stdsimd directories into the appropriate
crates/... directories - this simplifies creating crate.io releases of these crates
moves the top-level
coresimdandstdsimdsub-directories into theircorresponding crates in
crates/{core_arch, std_detect}.moves the examples into its own crate at
examples/to reduce the dev-dependencies ofstd_detectto a minimumAfter this PR lands rust-lang/rust#57808 could land. The main benefit is that we no longer build core::arch twice in rust-lang/rust, once in libstd, and once in libcore. Instead, these two PR change that to only build it once in libcore, and then libstd just re-export the
core::archmodule. The run-time feature detection is provided inlibstdby just addingstd_detetas a dependency, hopefully, without much hackery (since it is ait's only a#[no_std]library#[no_std]library on some archs, so we'll see how this goes). This also allows those#[no_std]users that want to have the exact same run-time feature detection system aslibstdto be able to do so by just addingstd_detectas a dependency.