Fixes for Clippy lints #1758
Open
Fixes for Clippy lints #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
reviewed
Feb 7, 2024
| @@ -45,7 +45,7 @@ impl GlacierCommand { | |||
| Some(Token::Quote(s)) => { | |||
| let source = s.to_owned(); | |||
| if source.starts_with("https://gist.github.com/") { | |||
| return Ok(Some(GlacierCommand { source })); | |||
| Ok(Some(GlacierCommand { source })) | |||
| } else { | |||
| return Err(toks.error(ParseError::InvalidLink)); | |||
There was a problem hiding this comment.
Why is this return not removed?
There was a problem hiding this comment.
Because clippy didn't say to remove it, but I suppose it may as well be removed. Will do
| @@ -72,17 +72,17 @@ impl NominateCommand { | |||
| if let Some(Token::Dot) | Some(Token::EndOfLine) = toks.peek_token()? { | |||
| toks.next_token()?; | |||
| *input = toks; | |||
| return Ok(Some(NominateCommand { team, style })); | |||
| Ok(Some(NominateCommand { team, style })) | |||
| } else { | |||
| return Err(toks.error(ParseError::ExpectedEnd)); | |||
| @@ -47,20 +47,20 @@ impl PingCommand { | |||
| if let Some(Token::Dot) | Some(Token::EndOfLine) = toks.peek_token()? { | |||
| toks.next_token()?; | |||
| *input = toks; | |||
| return Ok(Some(PingCommand { team })); | |||
| Ok(Some(PingCommand { team })) | |||
| } else { | |||
| return Err(toks.error(ParseError::ExpectedEnd)); | |||
| } | ||
| _ => {} | ||
| } | ||
| if args.len() == 2 && args[1] == "backlog_bonanza" { |
There was a problem hiding this comment.
I think leaving this as-is is better for future proofing.
| } | ||
| _ => {} | ||
| } | ||
| if args.len() == 2 && args[1] == "planning" { |
|
cc @pitaj in case you have time to tick these pending comments. In general I am not a big fan of massive linting patches, takes more time to review than prepare the patch :) (I assume changes have been tested - as far as possible with the triagebot codebase) Thanks! EDIT: also pls rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.