Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable buggy LTO #320

Merged
merged 11 commits into from
Nov 25, 2023
Merged

Disable buggy LTO #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a91f944
Disable LTO
Veetaha Nov 24, 2023
695e129
Add CI checks
Veetaha Nov 24, 2023
bc5935f
More comments
Veetaha Nov 24, 2023
c5fced9
Fix
Veetaha Nov 24, 2023
675967c
Small fix
Veetaha Nov 24, 2023
073667d
Fix
Veetaha Nov 24, 2023
3c3bb90
Disable LTO
Veetaha Nov 24, 2023
2ac442e
Don't fail fast. we want to know if other jobs are green or not
Veetaha Nov 24, 2023
d964a70
Update the changelog
Veetaha Nov 25, 2023
eae645d
Fix cargo release
Veetaha Nov 25, 2023
75fcdbc
Reduce the timeout for ARM build
Veetaha Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disable LTO
  • Loading branch information
@Veetaha
Veetaha committed Nov 24, 2023
commit a91f9442a3b9f166459ce8244537ec4aee1286e9
4 changes: 3 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ resolver = "2"

[profile.release]
codegen-units = 1
lto = true
strip = false

# ⚠️ Turns there is some bug in LTO on Windows, because it leads to the
# `marker_rustc_driver` crashing with "exit code: 0xc0000005, STATUS_ACCESS_VIOLATION"
lto = true

[workspace.package]
edition = "2021"
Expand Down
2 changes: 1 addition & 1 deletion cargo-marker/src/backend/driver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ fn build_driver(toolchain: &str, version: &str, mut additional_rustc_flags: Opti
// Build driver
let mut cmd = Cargo::with_toolchain(toolchain).command();
if is_local_driver() {
cmd.args(["build", "--bin", "marker_rustc_driver"]);
cmd.args(["build", "--bin", "marker_rustc_driver", "--release"]);
} else {
cmd.args(["install", "marker_rustc_driver", "--version", version, "--force"]);

Expand Down
Loading