Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ndarray 0.15 #273

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Conversation

cassiersg
Copy link
Contributor

Adding std feature is required since ndarray 0.15 made
impl std::error::Error for ShapeError require std.

Adding `std` feature is required since ndarray 0.15 made
`impl std::error::Error for ShapeError` require std.

Bump MSRV to 1.49 in linux-container CI to match the one of ndarray
(1.43 was giving errors in ndarray).
@cassiersg
Copy link
Contributor Author

@termoshtt If this is wanted, an update to rust 1.49.0 of the rustmath/mkl-rust would be needed (1.49 is the MSRV of ndarray 0.15).

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #273 (fbac1a9) into master (28c7860) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head fbac1a9 differs from pull request most recent head 06af362. Consider uploading reports for the commit 06af362 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   89.04%   88.95%   -0.09%     
==========================================
  Files          71       71              
  Lines        3586     3557      -29     
==========================================
- Hits         3193     3164      -29     
  Misses        393      393              
Impacted Files Coverage Δ
ndarray-linalg/src/cholesky.rs 97.14% <ø> (-0.05%) ⬇️
ndarray-linalg/src/eigh.rs 91.83% <ø> (+1.64%) ⬆️
ndarray-linalg/src/lobpcg/lobpcg.rs 92.12% <ø> (-0.82%) ⬇️
ndarray-linalg/src/lobpcg/svd.rs 85.36% <ø> (ø)
ndarray-linalg/src/solve.rs 72.58% <ø> (-0.08%) ⬇️
ndarray-linalg/src/solveh.rs 73.73% <ø> (+0.47%) ⬆️
ndarray-linalg/src/lobpcg/eig.rs 75.38% <100.00%> (ø)
ndarray-linalg/tests/cholesky.rs 100.00% <100.00%> (+4.08%) ⬆️
ndarray-linalg/src/operator.rs 85.00% <0.00%> (-5.00%) ⬇️
ndarray-linalg/src/layout.rs 85.29% <0.00%> (-2.95%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c7860...06af362. Read the comment docs.

@termoshtt termoshtt merged commit 06af362 into rust-ndarray:master Apr 11, 2021
@termoshtt
Copy link
Member

Merged with #277, thanks

termoshtt added a commit that referenced this pull request Apr 11, 2021
@termoshtt termoshtt added this to the 0.14.0 milestone Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants