Fix versions #1187
Merged
Fix versions #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, thanks for catching this. I think the only change needed here is fixing the changelogs -- can you amend the commit to remove the other version changes? We don't bump the package versions until we make a new release. You should still be able to use the not-yet-released version locally with |
LightAndLight
force-pushed
the
fix-versions
branch
from
16bd556
to
5e8b384
Compare
|
Done |
|
thanks! |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
nicholasbishop
force-pushed
the
fix-versions
branch
from
a5d048b
to
dfe6bad
Compare
|
I pushed a fix for the merge conflict. Seems CI is failing for unrelated reasons on the nightly test: #1205 |
nicholasbishop
force-pushed
the
fix-versions
branch
from
dfe6bad
to
cf0e0c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1186
uefi0.28 was released from commit 255359a. The tree for that commitdoesn't contain
ResetNotificationProtocol, even though the changelogsays it does.
ResetNotificationProtocolwas added in commit 04be50f,which was merged in commit
0c533bd- both occurring after 0.28 wasreleased.
This commit fixes those issues, and bumps the unreleased crate versions
so that I can depend on them before this commit is released.