-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xtask: Add action to generate a code coverage report #1423
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do we want to add an CI step and upload the html file as job artifact?
I was thinking of using one of the free-for-open-source platforms such as codecov.io or coveralls.io. I've used both, for example https://app.codecov.io/gh/nicholasbishop/ext4-view-rs and https://coveralls.io/github/google/sbat-rs. I've occasionally looked at doing some within-github-actions implementation that just stores the HTML files, but I've never found a particulary straightforward and easy way to do that, whereas uploading to one of the above websites is quite simple. |
This uses llvm-cov (https://github.com/taiki-e/cargo-llvm-cov) to create a simple HTML code coverage report. For now this only includes coverage from host tests, but in the future we can use https://github.com/Amanieu/minicov to include coverage from VM tests as well.
3365f36
to
1e5b0aa
Compare
This will be used to provide raw coverage data for the CI job.
1e5b0aa
to
0efe8dc
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Added a couple commits: add a |
This uses llvm-cov (https://github.com/taiki-e/cargo-llvm-cov) to create a simple HTML code coverage report.
For now this only includes coverage from host tests, but in the future we can use https://github.com/Amanieu/minicov to include coverage from VM tests as well.
Checklist