Add a new page that explains testing functions that use random generator #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give an example showing how to make a MockRng struct and use it instead, providing a default RNG as well
|
One problem with this solution is that if there are multiple tests that require different values, it won't work. The Default trait can be implemented only a single time. |
Fethbita
added a commit
to Fethbita/emrtd
that referenced
this pull request
Oct 5, 2024
The problem with this approach is that, different test functions can't use different states of the Rng. Also since the returned values are hardcoded in the MockRng, they are far away from the tests, should find another approach to be able to set the values Rng must return in the test functions themselves
|
Made the requested changes. Thanks for the comments. |
dhardy
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give an example showing how to make a MockRng struct and use it instead, providing a default RNG as well as recommended in rust-random/rand#1319.
Feel free to change the explanation or edit the code or leave feedback.