Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Patterns, Strategy has unclear identifier Context and run mentioned. #341

Closed
ppyrzanowski opened this issue Feb 5, 2023 · 1 comment · Fixed by #366
Closed

Design Patterns, Strategy has unclear identifier Context and run mentioned. #341

ppyrzanowski opened this issue Feb 5, 2023 · 1 comment · Fixed by #366
Labels
A-pattern Area: Content about Patterns C-clarification Category: Content that clarifies existing content good first issue Good for newcomers

Comments

@ppyrzanowski
Copy link
Contributor

A Context invariant and a run associated function are mentioned in the Strategy Pattern without any further explanation. I have the assumption that the example has been refactored but the description has been left unchanged, however, the file history does not show any major changes to the file.

A solution I propose and could complete is, cutting out any obscure mentioned identifiers in the description leaving the example as is.

Another solution is to give further context/sources/references to the obscure identifiers. This will probably include additions to the example.

I personally found the example very instructive and clear and would advocate to it leave unchanged.
@simonsan
Copy link
Collaborator

simonsan commented Apr 6, 2023

Do you want to open a PR with the changes you propose?

@simonsan simonsan added A-pattern Area: Content about Patterns C-amendment Category: Amendments to existing content C-clarification Category: Content that clarifies existing content good first issue Good for newcomers and removed C-amendment Category: Amendments to existing content labels Apr 6, 2023
ppyrzanowski added a commit to ppyrzanowski/patterns that referenced this issue Apr 19, 2023
@ppyrzanowski
Remove unknown Context identifier
fed1b49 
Fixes rust-unofficial#341 

Remove unknown `Context` identifier and rename unknown referenced `run` method to `format`.
@ppyrzanowski ppyrzanowski mentioned this issue Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-pattern Area: Content about Patterns C-clarification Category: Content that clarifies existing content good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unknown Context identifier ppyrzanowski/patterns
2 participants
@simonsan @ppyrzanowski