Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on #[non_exhaustive] for enums #168

Merged

Conversation

netzdoktor
Copy link
Contributor

No description provided.

@simonsan
Copy link
Collaborator

simonsan commented Jan 5, 2021

Hey thank you for the contribution, we are currently working on this in #135, issue is filed under #132 maybe you and @rcoh could work together on updating the article ;-)

@simonsan simonsan added the C-enhancement Category: Enhancements to content label Jan 5, 2021
@MarcoIeni
Copy link
Collaborator

Exactly, closing this. If you want to join the discussion in the issue or the PR you are welcome! :)

@MarcoIeni MarcoIeni closed this Jan 6, 2021
@simonsan
Copy link
Collaborator

simonsan commented Jan 6, 2021

We could merge this as a statement as long as the new article is not online, what do you think?

@MarcoIeni MarcoIeni reopened this Jan 6, 2021
@MarcoIeni MarcoIeni merged commit a0e7651 into rust-unofficial:master Jan 6, 2021
@simonsan
Copy link
Collaborator

simonsan commented Jan 6, 2021

Thank you for the contrib! ;-)

@netzdoktor netzdoktor deleted the priv-extend-non-exhaustive branch January 9, 2021 15:28
@netzdoktor
Copy link
Contributor Author

You're welcome. Tuning into the issue + PR you have mentioned.

Sorry for making this PR without checking existing work. I read the article and though I should file the PR before I forget, also because the change was rather simple. But revisiting the whole article for new state of Rust makes total sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancements to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants