[idioms/ctor] adds default constructor section #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookietreiber
force-pushed
the
idioms/constructor/default
branch
from
d6215c0
to
33c83d9
Compare
pickfire
reviewed
Oct 13, 2021
First, I replaced the `Vec` example with `Second`. This is easier to comprehend compared to the more complex `Vec` example. It's also testable because it doesn't rely on `RawVec`.
wookietreiber
force-pushed
the
idioms/constructor/default
branch
from
33c83d9
to
ca0207d
Compare
|
@wookietreiber Please don't force-push the branch, so we can keep review history. |
MarcoIeni
reviewed
Oct 17, 2021
replaces fn main examples with rustdoc examples
links to *associated function* to the book
Co-authored-by: Marco Ieni <11428655+MarcoIeni@users.noreply.github.com>
simonsan
reviewed
Nov 20, 2021
|
Anything else to add? @wookietreiber @pickfire @MarcoIeni |
MarcoIeni
reviewed
Nov 20, 2021
it messes up the formatting if you do
simonsan
previously approved these changes
Nov 21, 2021
simonsan
approved these changes
Nov 21, 2021
|
Thanks everyone, especially wookietreiber :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I replaced the
Vecexample withSecond. This is easier to comprehend compared to the more complexVecexample. It's also testable because it doesn't rely onRawVec.Discussion: #276