Mention Option::take() as an alternative to mem::replace() #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambda-fairy
reviewed
Oct 9, 2016
| @@ -53,6 +53,11 @@ result, we get the original `name` *as an owned value*. We can wrap this in | |||
| an `Option` or another enum that we can destructure in the next step to put the | |||
| contained values into our mutably borrowed enum. | |||
|
|
|||
| Note, however, that we you are using an `Option` and are replacing its | |||
There was a problem hiding this comment.
Nit: "we you" should be "when you"
There was a problem hiding this comment.
Oops. Fixed and hopefully improved a little overall.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not sure if this mention should go in the Motivation or Discussion sections. Since
Optionis being mentioned in the Motivation, however, I added it right there.