Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added information on --cap-lints to deny-warnings antipattern #58

Merged
merged 3 commits into from
Jan 2, 2021
Merged

added information on --cap-lints to deny-warnings antipattern #58

merged 3 commits into from
Jan 2, 2021

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Jun 5, 2017

This is an easier way to counter #[deny(warnings)] than finding and removing or commenting out the annotation.

nrc
nrc reviewed Jun 6, 2017
View reviewed changes
anti_patterns/deny-warnings.md Outdated Show resolved Hide resolved
@pickfire
Copy link
Contributor

@llogiq ping

@simonsan simonsan added the C-enhancement Category: Enhancements to content label Dec 31, 2020
@simonsan
Copy link
Collaborator

simonsan commented Dec 31, 2020 •
edited
Loading

@llogiq Could you please add an explanation for the difference between deny and forbid and rebase on master so we can merge? Thank you :-)

Did it ;-)

@simonsan simonsan added the C-waiting for Category: Waiting for feedback of the initial author or some external dependency/issue label Dec 31, 2020
@simonsan simonsan removed the C-waiting for Category: Waiting for feedback of the initial author or some external dependency/issue label Jan 1, 2021
simonsan
simonsan previously approved these changes Jan 1, 2021
View reviewed changes
@simonsan simonsan added the S-lgtm Status: Let's get this merged label Jan 1, 2021
@simonsan @MarcoIeni
Update anti_patterns/deny-warnings.md
9ccc7a2 
Co-authored-by: Marco Ieni <11428655+MarcoIeni@users.noreply.github.com>
@simonsan simonsan merged commit 721a6df into rust-unofficial:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc left review comments

@MarcoIeni MarcoIeni MarcoIeni left review comments

@simonsan simonsan simonsan approved these changes

Assignees
No one assigned
Labels
C-enhancement Category: Enhancements to content S-lgtm Status: Let's get this merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@llogiq @pickfire @simonsan @nrc @MarcoIeni