Enable x2apic for regular guests #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name Signed-off-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
skinsbursky
requested review from
russell-islam,
liuw,
NunoDasNeves and
jinankjain
as code owners
NunoDasNeves
approved these changes
Mar 18, 2024
russell-islam
approved these changes
Mar 19, 2024
Having x2apic enabled in Linux leads to MSI routing entries having physical mode enabled by default, which in turn allows to apply interrupt injection optimizations for the guests and increase the overall throughput. Signed-off-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
skinsbursky
force-pushed
the
skinsburskii/mshv/enable-x2apic
branch
from
e4a9e30
to
7af113a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This is needed to influence guest Linux to use physical address mode for MSIs (which it does by default when x2apic is enabled), which allows to support virtual interrupt injections in MSHV driver and thus improve overall VirtIO throughput.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.