Separate the builder attributes into multiple substates #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tomaka
force-pushed
the
gl-attribs
branch
3 times, most recently
from
85ac7fd
to
e5063c3
Compare
tomaka
changed the title
tomaka
force-pushed
the
gl-attribs
branch
5 times, most recently
from
d57a386
to
07640e7
Compare
|
cc @glennw I'm not sure if this compiles for android (the changes were made blindly). I'm going to land this anyway and the compilation will eventually be fixed in master. |
tomaka
added a commit
that referenced
this pull request
Sep 21, 2015
Separate the builder attributes into multiple substates
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
BuilderAttribsstruct and replaces it withGlAttributes,WindowAttributesandPixelFormatRequirements.The purpose of this change is to avoid passing windowing-related attributes to WGL/GLX/EGL, and get a better isolation.
Small breaking change: the
HeadlessRendererBuildernow takes a lifetime parameter to store the context to share lists with.cc #516
cc #517