Gamepad device events 2 #1969

maroider · 2021-06-25T15:33:33Z

Tested on all platforms changed
Compilation warnings were addressed
cargo fmt has been run on this branch
cargo doc builds successfully
Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created or updated an example program if it would help users understand this functionality
Updated feature matrix, if new features were added or implemented

I have now done as I suggested previously, and merged only the Windows implementation of #944 with master (ignore the bungled git history, lol). I have also made sure to set up the PR such that the only changes that need review are the ones specific to the gamepad-device-events-2 branch. Due to these decisions, this PR should be far easier to review than #1856.

I probably wouldn't have gotten as far as I have as quickly as I have without cross-referencing the work that @MarnixKuijs did in #1856, so thanks a lot for that :).

…indowing#804) * Initial implementation * Corrected RAWINPUT buffer sizing * Mostly complete XInput implementation * XInput triggers * Add preliminary CHANGELOG entry. * match unix common API to evl 2.0 * wayland: eventloop2.0 * make EventLoopProxy require T: 'static * Revamp device event API, as well as several misc. fixes on Windows: * When you have multiple windows, you no longer receive duplicate device events * Mouse Device Events now send X-button input * Mouse Device Events now send horizontal scroll wheel input * Add MouseEvent documentation and Device ID debug passthrough * Improve type safety on get_raw_input_data * Remove button_id field from MouseEvent::Button in favor of �utton * Remove regex dependency on Windows * Remove axis filtering in XInput * Make gamepads not use lazy_static * Publicly expose gamepad rumble * Unstack DeviceEvent and fix examples/tests * Add HANDLE retrieval method to DeviceExtWindows * Add distinction between non-joystick axes and joystick axes. This helps with properly calculating the deadzone for controller joysticks. One potential issue is that the `Stick` variant isn't used for *all* joysticks, which could be potentially confusing - for example, raw input joysticks will never use the `Stick` variant because we don't understand the semantic meaning of raw input joystick axes. * Add ability to get gamepad port * Fix xinput controller hot swapping * Add functions for enumerating attached devices * Clamp input to [0.0, 1.0] on gamepad rumble * Expose gamepad rumble errors * Add method to check if device is still connected * Add docs * Rename AxisHint and ButtonHint to GamepadAxis and GamepadButton * Add CHANGELOG entry * Update CHANGELOG.md * Add HidId and MovedAbsolute * Fix xinput deprecation warnings * Add ability to retrieve gamepad battery level * Fix weird imports in gamepad example * Update CHANGELOG.md * Resolve francesca64 comments

Add gamepad support for stdweb and web-sys, as well as web-specific gamepad examples. * [web] Fix compilation error from device api * [wasm] Apply device api changes * [wasm] Format and cleanup * [wasm32] Implement gamepad connections * [wasm] Harmonize * [Test] Made some tests with wasm-pack * Quick fix instant non supporting Hash trait * Fix on_received_character * [web_sys] Split add_event and add_window_event * [web] split device implementations * Update tests/web...still does not work * [tests/web] do not ignore index.html * [web/web_sys] split canvas and window * [tests/web] enable stack trace * [web] fix borrowmut * [web_sys] fix gamepad registration * [web] harmonize naming * [web_sys] create global emitter * [web] implement gamepad buttons * [web] implement gamepad axis * [web] cleanup * [web] update test * [web] move tests/web to examples/web * [web] axis does produce stick event * [web] Support Stick event * [web] implement gamepad to stdweb * [web] rename examples/web to examples/wasm * [web/web-sys] Move gamepad_manager from backend * [web/web_sys] implement EventLoop::gamepads * [web/web_sys] Drain gamepad events * [web/stdweb] apply web_sys changes * [web] update web/examples * [web] move gamepads code to gamepad_manager * [web] simplify and optimise * [web] replace EventCode to GamepadAxis and GamepadButton structs * [web] reuse gamepad events due to chrome issue * [web] rumble does not work * [web/stdweb] try debugging * [web] fix Chrome gamepad not updated * [web/stdweb] created an example * [examples] fix paths * fix warnings * [web/examples] update comments * [web/stdweb] add experimental support to vibrate() * [web] add CR

Co-authored-by: Marnix Kuijs <Marnix.Kuijs@embark-studios.com>

This reverts commit e004bd2.

msiglreith

Great, the API looks sensible to me and the implementation as well, thanks alot! - a few nits from my side.

src/event.rs

src/event/device.rs

msiglreith · 2021-06-29T20:28:16Z

src/platform_impl/windows/event_loop.rs

-                                device_id,
-                                event: Motion { axis: 1, value: y },
-                            });
+                        if x != 0.0 || y != 0.0 {


I think 0.0 would be valid for absolute position.

Yes, it should indeed be a valid position.

It turns out that my Wacom tablet will seemingly emit spurious events where the x and y position are both 0.0, even thought the pen is far from the upper left corner. I suspect this is in part due to winit not recognizing the digitizer as a separate "device", as the mouse ID in these events is 0x0.

msiglreith · 2021-06-29T20:32:03Z

src/platform_impl/windows/event_loop.rs

+                        if x != 0.0 || y != 0.0 {
+                            subclass_input.send_event(Event::MouseEvent(
+                                mouse_handle,
+                                MouseEvent::MovedAbsolute(PhysicalPosition { x, y }),


The returned positions are effectivley 16bit unorms iirc. This would require to map it to the current screen dimensions. Do you know in what coordinate system other platforms report absolute position? (0..screen | 0..1 | .. )

Do you know in what coordinate system other platforms report absolute position?

I have no idea.

So, I tested this with my Wacom tablet, since it's the only device I have that can report absolute position, and the coordinates it spits out are not normalized at all. It just gives me regular "pixel coordinates".

I plugged my old Wacom tablet as well and it reports values in the range of [0; 64k] following the Windows docs.
I had to disable Ink as it otherwise broke Raw Input for me (not reporting values at all only on entering/exiting a Window)

[src\platform_impl\windows\event_loop.rs:2226] (x, y, raw_mouse.usFlags) = ( 61224.0, 62378.0, MOUSE_MOVE_ABSOLUTE | MOUSE_VIRTUAL_DESKTOP, ) [src\platform_impl\windows\event_loop.rs:2226] (x, y, raw_mouse.usFlags) = ( 60098.0, 61524.0, MOUSE_MOVE_ABSOLUTE | MOUSE_VIRTUAL_DESKTOP, )

src/platform_impl/windows/raw_input.rs

src/util.rs

MarnixKuijs · 2021-06-30T14:58:20Z

Hype! Thank you for the hardwork. 🚀

Co-authored-by: Markus Siglreithmaier <m.siglreith@gmail.com>

FuriouZz · 2021-09-08T18:54:42Z

Any update?

maroider · 2021-09-08T19:19:45Z

I'm a bit busy right now IRL. I'll try to get some progress on the keyboard event rework this month, and then I'll have another look at this PR.

VZout · 2022-01-28T10:43:37Z

Hey! Do you require some additional help working on this? I can help out if you'd like. We are interested in using this!

maroider · 2022-01-28T10:45:39Z

It would be great to get some more data points on tablet/digitizer behaviour, as that's what got me stumped the last time I worked on this (see the unresolved review comments above for context).

VZout · 2022-01-28T11:04:13Z

👍 I'll find some devices to test on.

MultisampledNight · 2022-02-03T15:07:45Z

I'd be willing to test a bit, too, running on Wayland/X11 with both a normal touchscreen and a stylus.

IsaacMarovitz · 2024-01-07T01:31:32Z

Any update on gamepad support?

Osspial and others added 5 commits November 29, 2019 16:50

Merge branch 'master' into gamepad-device-events-2

a2bf8f2

Co-authored-by: Marnix Kuijs <Marnix.Kuijs@embark-studios.com>

Revert "Gamepad device events - Web/WASM (rust-windowing#1414)"

79b168c

This reverts commit e004bd2.

Update the doc section on device events in lib.rs

eb84dd8

maroider changed the title ~~Gamepad device events 2: elecrtic boogaloo~~ Gamepad device events 2 Jun 25, 2021

maroider added DS - windows C - waiting on maintainer A maintainer must review this code labels Jun 25, 2021

maroider requested a review from msiglreith June 25, 2021 15:47

msiglreith reviewed Jun 29, 2021

View reviewed changes

maroider and others added 4 commits July 3, 2021 22:22

Use correct pointer type

ff6254b

Co-authored-by: Markus Siglreithmaier <m.siglreith@gmail.com>

Use std's clamp function

ee96a89

Refer to the correct field on GamepadEvent::Axis

048ffaf

Allow absolute mouse motion to (0.0, 0.0)

0b5b01f

msiglreith mentioned this pull request Nov 1, 2022

Initial Xbox Gamepad support #2543

Closed

5 tasks

valaphee mentioned this pull request Feb 2, 2024

windows: HID raw input for gamepads and joysticks #3450

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gamepad device events 2 #1969

Gamepad device events 2 #1969

maroider commented Jun 25, 2021 •

edited

Loading

msiglreith left a comment

msiglreith Jun 29, 2021

maroider Jul 4, 2021

maroider Jul 4, 2021 •

edited

Loading

msiglreith Jun 29, 2021

maroider Jul 3, 2021

maroider Jul 4, 2021

msiglreith Jul 8, 2021

MarnixKuijs commented Jun 30, 2021

FuriouZz commented Sep 8, 2021

maroider commented Sep 8, 2021

VZout commented Jan 28, 2022

maroider commented Jan 28, 2022 •

edited

Loading

VZout commented Jan 28, 2022

MultisampledNight commented Feb 3, 2022

IsaacMarovitz commented Jan 7, 2024

Gamepad device events 2 #1969

Are you sure you want to change the base?

Gamepad device events 2 #1969

Conversation

maroider commented Jun 25, 2021 • edited Loading

msiglreith left a comment

Choose a reason for hiding this comment

msiglreith Jun 29, 2021

Choose a reason for hiding this comment

maroider Jul 4, 2021

Choose a reason for hiding this comment

maroider Jul 4, 2021 • edited Loading

Choose a reason for hiding this comment

msiglreith Jun 29, 2021

Choose a reason for hiding this comment

maroider Jul 3, 2021

Choose a reason for hiding this comment

maroider Jul 4, 2021

Choose a reason for hiding this comment

msiglreith Jul 8, 2021

Choose a reason for hiding this comment

MarnixKuijs commented Jun 30, 2021

FuriouZz commented Sep 8, 2021

maroider commented Sep 8, 2021

VZout commented Jan 28, 2022

maroider commented Jan 28, 2022 • edited Loading

VZout commented Jan 28, 2022

MultisampledNight commented Feb 3, 2022

IsaacMarovitz commented Jan 7, 2024

maroider commented Jun 25, 2021 •

edited

Loading

maroider Jul 4, 2021 •

edited

Loading

maroider commented Jan 28, 2022 •

edited

Loading