Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowBuilderExtWebSys::with_prevent_default disables scrolling on both mobile and desktop (previously just desktop) #2216

Merged
merged 5 commits into from
Sep 4, 2022
Merged

WindowBuilderExtWebSys::with_prevent_default disables scrolling on both mobile and desktop (previously just desktop) #2216

merged 5 commits into from
Sep 4, 2022

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Mar 5, 2022

closes #2116

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Tested on firefox on my desktop and firefox on my android phone.

@rukai rukai force-pushed the improve_web_scroll_handling branch from ff4dd96 to bc5680f Compare March 5, 2022 02:59
@maroider maroider added DS - android C - waiting on maintainer A maintainer must review this code labels Mar 5, 2022
@rukai
Copy link
Contributor Author

rukai commented Mar 5, 2022

Hmmmm not sure how much it matters but should be tagged web not android

madsmtm
madsmtm reviewed Apr 17, 2022
View reviewed changes
src/platform_impl/web/web_sys/canvas.rs Outdated Show resolved Hide resolved
src/platform/web.rs Outdated Show resolved Hide resolved
@rukai rukai force-pushed the improve_web_scroll_handling branch from bc5680f to dd254c5 Compare April 23, 2022 23:49
@rukai rukai force-pushed the improve_web_scroll_handling branch from c4ef57f to 5850030 Compare July 12, 2022 23:28
@rukai rukai force-pushed the improve_web_scroll_handling branch 3 times, most recently from 1038171 to 6ae6207 Compare September 2, 2022 23:29
@rukai rukai changed the title Disable scrolling on web by default but provide method in builder to enable it WindowBuilderExtWebSys::with_prevent_default disables scrolling on both mobile and desktop (previously just desktop) Sep 3, 2022
@rukai rukai force-pushed the improve_web_scroll_handling branch from e635978 to 44fb436 Compare September 4, 2022 02:46
madsmtm
madsmtm approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good!

I modified the changlog entry to note it as a breaking change, while it doesn't change the API it changes the semantics. Will merge when CI finishes

@madsmtm madsmtm merged commit 0fca8b0 into rust-windowing:master Sep 4, 2022
@rukai rukai mentioned this pull request Sep 4, 2022
Closed
13 tasks
@daxpedda daxpedda mentioned this pull request Jun 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
C - waiting on maintainer A maintainer must review this code DS - web
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scrolling is not captured on web mobile
3 participants
@rukai @madsmtm @maroider