New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed shard retrieval #25

Merged

rwynn merged 2 commits into rwynn:master from antonsergeyev:get-shards-fix

Dec 4, 2020

Contributor

antonsergeyev commented Dec 4, 2020 •

edited

Loading

This fixes 2 problems I've encountered when working with sharded mongodb cluster:

GetShards function always returned empty results, because a filter query was incorrect (it used nil as a filter instead of bson.D{})
If there are multiple comma-separated hostnames for different mongodb replicas in each shard, the GetUrl function returned invalid URLs. Now it returns a first URL from the comma-separated list, which is imperfect, but at least it works.

antonsergeyev added 2 commits

December 4, 2020 12:02


          fixed shard retrieval

0959c01


          url format fixed

67b8895

rwynn merged commit 9a7f147 into rwynn:master

Owner

rwynn commented Dec 6, 2020

@antonsergeyev thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet