0.29 stable #1
Open
0.29 stable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Ensure the loopback exemption is added for app for access to localhost (i.e., the packager server). Fixes microsoft#515
Removing the AppPackages folder was causing the packager to crash. Avoiding the removal. Fixes microsoft#517
microsoft#525) VisualTreeHelper is able to find the parent dependency object in cases where the FrameworkElement.Parent property may be null. This is a useful way to ensure we can find the RootView for measurement. Hacking this helper, however, breaks certain views like SplitView, which currently depend on the pointer not being captured by React to close the view when the lightweight Rect layer is overlayed adjacent to the pane. For now, only using the VisualTreeHelper in the root view search case, however we may want to use it more generally and have a better "opt-out" mechanism for view managers like SplitView.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Resolves [Add Relevant Issue Here]
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Optional: Describe the tests that you ran locally to verify your changes.