Fully finish the GatewayAlarm class and fix style issues #633

starkillerOG · 2020-02-19T20:12:45Z

I have fully tested and varified all functions in the GatewayAlarm class.
I have moved all functions related to the GatewayAlarm out of the Gateway class.
I run black on top of the file to fix lots of styling issues.

This includes everything of PR: #630, so I will close that one.

Since this does not have to do with the gateway (I think)

miio/gateway.py

coveralls · 2020-02-19T20:14:18Z

Coverage increased (+0.06%) to 71.037% when pulling 647f39d on starkillerOG:patch-2 into 46a1a46 on rytilahti:gateway.

miio/gateway.py

starkillerOG · 2020-02-19T20:49:44Z

@rytilahti could you please merge this PR?
I have cleaned up the Gateway PR a lot in this PR and everythin that has to do with the GatewayAlarm is now included in a seprate class that is fully tested and working.

.flake8.ini

miio/gateway.py

Co-Authored-By: Teemu R. <tpr@iki.fi>

miio/gateway.py

starkillerOG · 2020-02-19T21:41:27Z

@rytilahti all finished, I think I have adressed all improvements you pointed out.
Any more suggestions, or can this be merged?

(only the device class left, schould it be underneath Gateway class or not...)

starkillerOG · 2020-02-20T18:40:48Z

@rytilahti The GatewayAlarm can now be used from the Gateway class.
The following works in python3:

from miio import (Device, gateway)
miio_device = Device("IP_of_the_gateway", 'token_of_the_gateway')
gateway = gateway.Gateway(miio_device)
gateway.alarm.status() #--> response: 'off'
gateway.alarm.on() #--> response: ['OK']
gateway.alarm.status() #--> response: 'oning'
#wait some time
gateway.alarm.status() #--> response: 'on'
gateway.alarm.off() #--> response: ['OK']
gateway.alarm.status() #--> response: 'off'

starkillerOG · 2020-02-20T18:41:41Z

@rytilahti can this now be merged?

starkillerOG · 2020-02-23T11:55:36Z

@rytilahti could you merge this and push to a new version so I can continue with the HomeAssistant PR as refrenced?

rytilahti

Sorry for the delay, if you could make those two changes and update the README to add this device, I think we can merge it as partially supported.

miio/gateway.py

starkillerOG · 2020-03-05T21:32:06Z

@rytilahti no problem!
I made the changes requested and tested the code, it works.
I also added the xiaomi aqara gateway to the readme.

I think this can now be merged.

rytilahti · 2020-03-06T01:28:23Z

Great, thanks 👍 I'll take care of cleaning up the original PR and get it merged for a new release.

* add new line * remove To Do comment Since this does not have to do with the gateway (I think) * Fully finish the GatewayAlarm class * black fix styles * fix hound issue * flake8 was wrong, black is wright * ignore flake8 E203 error since black handles that * Turning --> Turn Co-Authored-By: Teemu R. <tpr@iki.fi> * Turning --> Turn Co-Authored-By: Teemu R. <tpr@iki.fi> * add type return Co-Authored-By: Teemu R. <tpr@iki.fi> * add flake8 exception for single line * remove global flake8 ignore * add extra space * add return types * fix return types * datatime.datetime is unknown type * remove print() * Reorganize classes * Use parent and improve init * Add Xiaomi Aqara Gateway to readme Co-authored-by: Teemu R. <tpr@iki.fi>

* WIP: gateway support thanks to dgi (dustcloud fame) and javascript miio lib * add set_gateway_volume, slight fixes * port over to the new cli api, remove MessageNet which was supposed only for testing * Added more light controls for gateway (#624) * added color and brightness functionality * added command to set both color and brightness * linting fixes * Fully finish the GatewayAlarm class and fix style issues (#633) * add new line * remove To Do comment Since this does not have to do with the gateway (I think) * Fully finish the GatewayAlarm class * black fix styles * fix hound issue * flake8 was wrong, black is wright * ignore flake8 E203 error since black handles that * Turning --> Turn Co-Authored-By: Teemu R. <tpr@iki.fi> * Turning --> Turn Co-Authored-By: Teemu R. <tpr@iki.fi> * add type return Co-Authored-By: Teemu R. <tpr@iki.fi> * add flake8 exception for single line * remove global flake8 ignore * add extra space * add return types * fix return types * datatime.datetime is unknown type * remove print() * Reorganize classes * Use parent and improve init * Add Xiaomi Aqara Gateway to readme Co-authored-by: Teemu R. <tpr@iki.fi> * Cleanup gateway for initial release * fix import sorting Co-authored-by: Maksim Melnikov <approximatenumber@gmail.com> Co-authored-by: starkillerOG <starkiller.og@gmail.com>

starkillerOG · 2020-03-17T07:56:36Z

@rytilahti do you know when you will push to a new version of miho?

starkillerOG added 4 commits February 19, 2020 19:15

add new line

3bae13f

remove To Do comment

f5f117a

Since this does not have to do with the gateway (I think)

Fully finish the GatewayAlarm class

8f217b9

black fix styles

0eeb1ce

houndci-bot reviewed Feb 19, 2020

View reviewed changes

miio/gateway.py Outdated Show resolved Hide resolved

fix hound issue

17d327f

houndci-bot reviewed Feb 19, 2020

View reviewed changes

miio/gateway.py Outdated Show resolved Hide resolved

starkillerOG added 2 commits February 19, 2020 21:27

flake8 was wrong, black is wright

39e6929

ignore flake8 E203 error since black handles that

bb7345a

starkillerOG mentioned this pull request Feb 19, 2020

Add support for Xiaomi Aqara Gateway Alarm #630

Closed

rytilahti reviewed Feb 19, 2020

View reviewed changes

starkillerOG and others added 4 commits February 19, 2020 22:12

Turning --> Turn

3f9f54f

Co-Authored-By: Teemu R. <tpr@iki.fi>

Turning --> Turn

7edc830

Co-Authored-By: Teemu R. <tpr@iki.fi>

add type return

173ea16

Co-Authored-By: Teemu R. <tpr@iki.fi>

add flake8 exception for single line

36cf046

houndci-bot reviewed Feb 19, 2020

View reviewed changes

miio/gateway.py Outdated Show resolved Hide resolved

starkillerOG added 3 commits February 19, 2020 22:21

remove global flake8 ignore

51a98e9

add extra space

37f3238

add return types

725073b

houndci-bot reviewed Feb 19, 2020

View reviewed changes

miio/gateway.py Outdated Show resolved Hide resolved

miio/gateway.py Outdated Show resolved Hide resolved

starkillerOG added 2 commits February 19, 2020 22:35

fix return types

9a68456

datatime.datetime is unknown type

2f41fc5

starkillerOG added 2 commits February 19, 2020 23:39

remove print()

d367da4

Reorganize classes

95694bd

starkillerOG mentioned this pull request Feb 22, 2020

Add Xiaomi miio Alarm Control Panel home-assistant/core#32091

Merged

20 tasks

rytilahti approved these changes Mar 5, 2020

View reviewed changes

miio/gateway.py Outdated Show resolved Hide resolved

miio/gateway.py Outdated Show resolved Hide resolved

miio/gateway.py Outdated Show resolved Hide resolved

starkillerOG added 2 commits March 5, 2020 22:15

Use parent and improve init

d16f3fa

Add Xiaomi Aqara Gateway to readme

647f39d

rytilahti merged commit 420b659 into rytilahti:gateway Mar 6, 2020

rytilahti mentioned this pull request Apr 20, 2020

Gateway not responding #680

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fully finish the GatewayAlarm class and fix style issues #633

Fully finish the GatewayAlarm class and fix style issues #633

starkillerOG commented Feb 19, 2020 •

edited

Loading

coveralls commented Feb 19, 2020 •

edited

Loading

starkillerOG commented Feb 19, 2020

starkillerOG commented Feb 19, 2020

starkillerOG commented Feb 20, 2020

starkillerOG commented Feb 20, 2020

starkillerOG commented Feb 23, 2020

rytilahti left a comment •

edited

Loading

starkillerOG commented Mar 5, 2020

rytilahti commented Mar 6, 2020

starkillerOG commented Mar 17, 2020

Fully finish the GatewayAlarm class and fix style issues #633

Fully finish the GatewayAlarm class and fix style issues #633

Conversation

starkillerOG commented Feb 19, 2020 • edited Loading

coveralls commented Feb 19, 2020 • edited Loading

starkillerOG commented Feb 19, 2020

starkillerOG commented Feb 19, 2020

starkillerOG commented Feb 20, 2020

starkillerOG commented Feb 20, 2020

starkillerOG commented Feb 23, 2020

rytilahti left a comment • edited Loading

Choose a reason for hiding this comment

starkillerOG commented Mar 5, 2020

rytilahti commented Mar 6, 2020

starkillerOG commented Mar 17, 2020

starkillerOG commented Feb 19, 2020 •

edited

Loading

coveralls commented Feb 19, 2020 •

edited

Loading

rytilahti left a comment •

edited

Loading