Fixes #2 - adds faster sensor reading #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sends expected data lines with each OBD command to speed up communication. According to the ELM327 datasheet you can send a single hex number at the end of a request that represents how many lines of data to expect. You can read more about this on page 33 in the data sheet.
For each data line there are 4 bytes, so this change takes the data width (amount of bytes) and divides it by 4 to get the amount of data lines. Currently this value will always be 1, since there are no commands that return more than 4 bytes. Instead of hard coding it to 1, we have a future proof solution.
Checklist
go testlocally is successful