Feat/faster thumbnail #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrogden
approved these changes
Dec 29, 2023
|
https://github.com/sabrogden/Ditto/releases/tag/nightly not sure on this, it's pretty low quality |
Thank you! I agreed with your opinion, so I tested again and found a little point to improve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #581 partially (but not small effect).
before fix it, thumbnail uses interpolation mode as HighQualityBicubic that expensive than NearestNeighbor.
Therefore resizing of big image such as 6720x4480, 7680x4320 takes about 200ms each.
If changed the interpolation NearestNeighbor it just takes 50ms(4x faster).
Since thumbnails are generally not critical to quality, I set the default value of 'Fast Thumbnail Mode' to true to use the Nearest Neighbor mode.
Built and tested manually using Visual Studio.