MDL-63422 auth_cas: review core loop / switch / case / continue

Created apereo/phpCAS#278 upstream, applied locally.
safatshahin · Oct 30, 2018 · 0d2d2b9 · 0d2d2b9
1 parent bd5fdcf
commit 0d2d2b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/auth/cas/CAS/CAS/Client.php b/auth/cas/CAS/CAS/Client.php
@@ -3380,7 +3380,7 @@ private function _readExtraAttributesCas20($success_elements)
                 case 'user':
                 case 'proxies':
                 case 'proxyGrantingTicket':
-                    continue;
+                    break;
                 default:
                     if (strlen(trim($attr_node->nodeValue))) {
                         phpCas :: trace(

diff --git a/auth/cas/CAS/moodle_readme.txt b/auth/cas/CAS/moodle_readme.txt
@@ -1,4 +1,5 @@
 Description of phpCAS 1.3.5 library import
 
 * downloaded from http://downloads.jasig.org/cas-clients/php/current/
-* applied patch https://github.com/apereo/phpCAS/pull/247 for PHP 7.2 compatibility (MDL-60280)
+* applied patch https://github.com/apereo/phpCAS/pull/247 for PHP 7.2 compatibility (MDL-60280)
+* applied patch https://github.com/apereo/phpCAS/pull/278 for PHP 7.3 compatibility (MDL-63422)